Skip to content

Use AnnotationUtils.findAnnotation(…) instead of AnnotatedElement.isAnnotationPresent(…) to support meta-annotations #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use AnnotationUtils.findAnnotation(…) instead of AnnotatedElement.isAnnotationPresent(…) to support meta-annotations #2500

wants to merge 1 commit into from

Conversation

XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Nov 22, 2021 •
edited
Loading

…

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2021
@XenoAmess XenoAmess force-pushed the change_from_java's_isAnnotationPresent_to_spring's_findAnnotation branch from 13ebc50 to b5af524 Compare November 22, 2021 20:50
@XenoAmess
Copy link
Contributor Author

Hi. I thought original tests are enough.

Need I still add some?

@mp911de mp911de self-assigned this Nov 23, 2021
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 8, 2021
@mp911de mp911de added this to the 2.7 M1 (2022.0.0) milestone Dec 8, 2021
@mp911de mp911de closed this in ca723d1 Dec 8, 2021
mp911de added a commit that referenced this pull request Dec 8, 2021
@mp911de
Polishing.
4e6bffb 
Extract duplicate calls to findAnnotation(…) into static helper methods.

See #2500
@mp911de mp911de changed the title change from java's isAnnotationPresent to spring's findAnnotation, for MergedAnnotations can be used. Use AnnotationUtils.findAnnotation(…) instead of AnnotatedElement.isAnnotationPresent(…) to support meta-annotations Dec 8, 2021
@mp911de
Copy link
Member

mp911de commented Dec 8, 2021

Thank you for your contribution. That's merged and polished now.

mp911de added a commit that referenced this pull request Dec 8, 2021
@mp911de
Polishing.
ef522f8 
Extract duplicate calls to findAnnotation(…) into static helper methods.

See #2500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
2.7 M1 (2021.2.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@XenoAmess @mp911de @spring-projects-issues